-
Notifications
You must be signed in to change notification settings - Fork 290
Add Codecov Test Analytics #1684
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Codecov Test Analytics #1684
Conversation
CodSpeed Performance ReportMerging #1684 will not alter performanceComparing Summary
|
Hey @Viicos, saw you're pretty active on this repo and was wondering if you / the team would be interested in trying this out? |
@@ -46,7 +46,7 @@ jobs: | |||
|
|||
- run: uv pip freeze | |||
|
|||
- run: uv run coverage run -m pytest | |||
- run: uv run coverage run -m pytest --junitxml=junit.xml -o junit_family=legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering: why can't Codecov read the "normal" coverage output file and needs a junitxml output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting back, the JunitXML is needed to actually do the test analysis, because the normal coverage output file doesn't give us any test-specific information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Viicos just wanted to bump this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ajay-sentry
This PR aims to add Codecov's Test Analytics feature to the pydantic-core repository. With Test Analytics, there are 2 main features:
More information can be found here: https://docs.codecov.com/docs/test-analytics#failed-test-reporting
For this PR the test tab for this branch is now populated: https://app.codecov.io/github/pydantic/pydantic-core/tests/ajay-sentry%3AAjay%2Fcodecov-test-analytics
As more PRs are merged the "main" branch view including the metric dashboard at the top will also be populated, similar to how Codecov's are: https://app.codecov.io/github/codecov/gazebo/tests/main
Change Summary
I saw we were already using the latest version of the codecov action, this PR adds the codecov test results action right below it, keeping the same styling in the file otherwise. I did also need to add the option of creating a junit xml to the pytest setup so that the test results action can pick it up and upload it to codecov though
Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)