-
Notifications
You must be signed in to change notification settings - Fork 290
Add ensure_ascii
option
#1689
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Add ensure_ascii
option
#1689
Conversation
} | ||
} | ||
|
||
macro_rules! defer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per @cetra3's suggestion. The match statement in to_json_bytes
isn't going to scale well, so maybe an alternative API should be used in the future.
CodSpeed Performance ReportMerging #1689 will not alter performanceComparing Summary
|
}; | ||
} | ||
|
||
#[allow(clippy::needless_lifetimes)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a false positive from Clippy? There are already a bunch.
Any chance you'd follow the core python default FYI, the
|
This can only be done in Pydantic V3, and still I don't know if the motivation is strong enough to do the change. |
Change Summary
Part of pydantic/pydantic#11202.
Related issue number
Checklist
pydantic-core
(except for expected changes)