DEV - Miscellaneous enhancements to CI #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
tag: CI
|
Ok graphviz action substituted, and it seems installs are working as expected so will mark as ready for review |
trallard
commented
Jul 15, 2024
Comment on lines
+13
to
+16
| graphviz: | ||
| description: Whether this should install Graphviz or not | ||
| required: false | ||
| default: "false" |
There was a problem hiding this comment.
I tried to change this to the GH actions boolean false and setting the type: boolean here but GH actions complained that this had to be a string 🤷🏽 not sure why so left it as a string for now
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
drammock
approved these changes
Jul 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a couple of fixes to the CI workflows: