Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates for file src/pydata_sphinx_theme/locale/en/LC_MESSAGES/sphinx.po in zh #1936

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

transifex-integration[bot]
Copy link
Contributor

The following localization files have been updated:

Parameter Value
Source File src/pydata_sphinx_theme/locale/en/LC_MESSAGES/sphinx.po
Translation File src/pydata_sphinx_theme/locale/zh/LC_MESSAGES/sphinx.po
Language Code zh
Transifex Project pydata-sphinx-theme
Transifex Resource src..LC_MESSAGES/sphinx.po (main)
Transifex Event translated

transifex-integration bot and others added 7 commits July 20, 2024 01:30
100% translated source file: 'sphinx.po'
on 'zh'.
100% translated source file: 'sphinx.po'
on 'zh'.
100% translated source file: 'sphinx.po'
on 'zh'.
100% translated source file: 'sphinx.po'
on 'zh'.
100% translated source file: 'sphinx.po'
on 'zh'.
100% translated source file: 'sphinx.po'
on 'zh'.
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

drammock
drammock previously approved these changes Jul 22, 2024
@drammock
Copy link
Collaborator

@Carreau the transifex header changes precommit hook is too sensitive here --- this is a new file and it's still trying to suppress the "changed" header lines.

Not sure who to tag as author, as I don't think "温欣" is @hanteng from #1898 ... but I'm wondering why "面包屑导航" for "breadcrumb" wasn't included?

@Carreau
Copy link
Collaborator

Carreau commented Jul 23, 2024

the transifex header changes precommit hook is too sensitive here --- this is a new file and it's still trying to suppress the "changed" header lines.

I'm confused about what that means. Where do you see this error message ?

I guess we should send a issue upstream : https://github.com/mondeja/pre-commit-po-hooks

@drammock
Copy link
Collaborator

the transifex header changes precommit hook is too sensitive here --- this is a new file and it's still trying to suppress the "changed" header lines.

I'm confused about what that means. Where do you see this error message ?

Never mind, I was misunderstanding. In 8cde753 the header info is being removed. It gets put back by the subsequent commit (and is apparently not auto-fixed again in such cases), which then causes the pre-commit.ci job to fail. So we just need to re-trigger the auto-fix.

@drammock drammock merged commit 22ee6af into main Jul 23, 2024
29 checks passed
@drammock drammock deleted the translations_79592a50a377d7a120926189491c3d76_zh branch July 23, 2024 22:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants