-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs: Fix search UI description #1988
Conversation
Updates the search doc in the user guide to describe the default search UI on both narrow and wide viewports. Also breaks all lines in the doc at 80-characters width. Fix: pydata#1781
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
in future it would help if you separated wrapping/whitespace-only changes in a separate commit from substantive changes to the content, so we can more easily know what parts of the diff are safe to ignore.
Co-authored-by: Daniel McCloy <dan@mccloy.info>
thanks for review @drammock, will send separate commits in the future (also easy for me to revert the whitespace fixes if you want this commit to only have the content update) |
No need, I already checked it since the diff was not too large |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Updates the search doc in the user guide to describe the default search UI on both narrow and wide viewports.
Also breaks all lines in the doc at 80-characters width.
Fix: #1781