Use Playwright expect() for code block tab stop tests #2160

gabalafou · 2025-03-10T20:58:04Z

Maybe fixes #2158.

This takes advantage of Playwright's ability to wait for a condition to be true rather than hard-coding manual wait times with the page.wait_for_timeout() function.

From the Playwright docs:

Playwright includes assertions that will wait until the expected condition is met. Using these assertions allows making the tests non-flaky and resilient.
-Writing Tests: Assertions

This takes advantage of Playwright's own ability to wait for the condition to be true rather than calling wait_for_timeout manually

For the code block tab stop tests use Playwright expect() assertion

12b2424

This takes advantage of Playwright's own ability to wait for the condition to be true rather than calling wait_for_timeout manually

gabalafou changed the title ~~For the code block tab stop tests use Playwright expect() assertion~~ Use Playwright expect() assertion for the code tab stop tests Mar 10, 2025

gabalafou changed the title ~~Use Playwright expect() assertion for the code tab stop tests~~ Use Playwright expect() for the code tab stop tests Mar 10, 2025

gabalafou changed the title ~~Use Playwright expect() for the code tab stop tests~~ Use Playwright expect() for code block tab stop tests Mar 10, 2025

clean up comments

528eff0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Playwright expect() for code block tab stop tests #2160

Use Playwright expect() for code block tab stop tests #2160

gabalafou commented Mar 10, 2025 •

edited

Loading

Use Playwright expect() for code block tab stop tests #2160

Are you sure you want to change the base?

Use Playwright expect() for code block tab stop tests #2160

Conversation

gabalafou commented Mar 10, 2025 • edited Loading

gabalafou commented Mar 10, 2025 •

edited

Loading