-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
silence UnitStrippedWarnings #4163
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
silence UnitStrippedWarnings #4163
Conversation
unfortunately, this doesn't seem to really work: |
I just saw your message from a couple of days ago @keewis . |
I tried that by writing some sort of So to make this work I think we'd need to rewrite Edit: Right now the only failing tests are due to hgrecco/pint#1123. I guess I'll just remove the xfail condition and add it back once that PR is merged. |
Once the CI passes this should be ready for review and merging. |
Thanks @keewis. I'm really excited to see this go in. |
* master: Add initial cupy tests (pydata#4214) Add 0.16.0 release summary New whatsnew section Release v0.16.0 Minor reorg of whatsnew for 0.16.0 (pydata#4216) fix sphinx warnings (pydata#4199) pin isort (pydata#4206) get the colorbar label via public methods (pydata#4201) Bump minimum versions for 0.16 release (pydata#4175) Allow passing axis kwargs to plot (pydata#4020) Fix to_unstacked_dataset for single dimension variables. (pydata#4094) Improve the speed of from_dataframe with a MultiIndex (by 40x!) (pydata#4184) More pint compatibility: silence UnitStrippedWarnings (pydata#4163) Fix typo (pydata#4192) use the latest image of RTD (pydata#4191)
Now that the tests are cleaned up, it is time to fix the numerous "unit stripped" warnings. We'll get there by promoting all
UnitStrippedWarning
s to errors (usingfilterwarnings
) and fixing / xfailing the failing tests.isort -rc . && black . && mypy . && flake8
whats-new.rst
for all changes andapi.rst
for new API