Cleanup logic inside `open_dataset`, mostly `extra_kwargs` #4462

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merged

shoyer merged 2 commits into pydata:master from bopen:extra_kwargs_cleanup

Oct 8, 2020

Collaborator

alexamici commented Sep 25, 2020

This is a small, pure code-refactor PR that removes some of the cruft left in open_dataset from #4187 and #4431

Additional clean ups after Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. #4431
Pure code refactor, no change in tests
Passes isort . && black . && mypy . && flake8

Note that mode="r" is the default in open_group.


          Cleanup logic inside open_dataset, mostly extra_kwargs

2f864e6

alexamici mentioned this pull request

Autodetect the engine only when engine=None #4458

Merged

5 tasks


          Merge remote-tracking branch 'upstream/master' into extra_kwargs_cleanup

ecd7539

shoyer merged commit 6dc3c75 into pydata:master

alexamici added the grant-czi label

alexamici added the topic-backends label

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

grant-czi topic-backends