Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

Add support for CBOR tags #172

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Add support for CBOR tags #172

merged 1 commit into from
Jan 9, 2020

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jan 6, 2020

Using a thread local value as a way to get the tag value over the fence from the CBOR format to a CBOR aware serializer/deserializer.

Replaces #164

Here is a more complex real world use case from @vmx : https://github.com/vmx/rust-ipld-dag-cbor

Using a thread local value as a way to get the tag value over the fence
from the CBOR format to a CBOR aware serializer.
@rklaehn
Copy link
Contributor Author

rklaehn commented Jan 6, 2020

As discussed in #164, the tags feature should not be enabled by default since it changes the deserialization behavior for non tag aware data structures when tags are present.

Not sure if serde_cbor::Value::Tag should exist when the feature is disabled.

@pyfisch
Copy link
Owner

pyfisch commented Jan 9, 2020

Thanks for all your work! 🎉

I will release the new version to crates.io soon.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants