Add main guard to examples (+ incredibly small fixes) #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might need a better name because it does not fix just that the PR. |
damusss
changed the title
bilhox
approved these changes
Oct 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Starbuck5 pointed out on discord, many example lack the
guard and could run unexpectedly if auto-imported by some (not smart) IDE.
This PR fixes this.
You may also notice 2 or 3 very small unrelated fixes, I think they can pass too.
All examples still run, but you can run yourself aswell. I did the minimum refactoring possible.
NOTE: the diff github renders is kinda crazy, 99% of the time I just added one tab of indentation to the main functionality, I didn't actually change anything. You might want to compare them locally (or trust me).