-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: replace imp with importlib #919
Conversation
@bitprophet looks like I got the tests working. Need to remove |
@bitprophet alright |
I have additional changes to remove the parent path from 'load()' and retrieve it from the module. But that's something that could have been done before so... |
Great! Hope this gets merged soon. |
@jefftriplett could you give this a review? |
@bitprophet ping |
I'll try to find the time to review this in depth next time I'm doing Invoke-y things. Pairs well with the typing update that is yet unreleased, I'd prob pop both out as a 'support' minor version bump when I do this. thanks! 🙏🏻 |
Great to see you back. For the release... there's one caveat, I removed decorator.py because it wasn't used but then realized it's being consumed by fabric. |
Thrusting my head above the surface of the Paramiko swamp for a gasp of air & to actually look at this 🙏🏻 unless something drastic happens I'll try to pop out invoke 2.1 today with this plus all of your other recent work! |
Rebased onto an unrelated fix so now github's behind the times, but this is merged and on pypi! thanks again 🙏🏻 |
@bitprophet This is mostly there. Just need to sort the issues with
program
.