Fix a crash in the optional private_import extension

pylint-dev · Jun 6, 2022 · 6fac84e · 6fac84e
1 parent 3ac7d11
commit 6fac84e
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/doc/whatsnew/2/2.14/full.rst b/doc/whatsnew/2/2.14/full.rst
@@ -22,6 +22,10 @@ Release date: TBA
 
   Closes #6810
 
+* Fix a crash in the optional ``pylint.extensions.private_import`` extension.
+
+  Closes #6624
+
 
 What's New in Pylint 2.14.0?
 ----------------------------

diff --git a/pylint/extensions/private_import.py b/pylint/extensions/private_import.py
@@ -234,7 +234,8 @@ def _assignments_call_private_name(
             while isinstance(current_attribute, (nodes.Attribute, nodes.Call)):
                 if isinstance(current_attribute, nodes.Call):
                     current_attribute = current_attribute.func
-                current_attribute = current_attribute.expr
+                if not isinstance(current_attribute, nodes.Name):
+                    current_attribute = current_attribute.expr
             if (
                 isinstance(current_attribute, nodes.Name)
                 and current_attribute.name == private_name

diff --git a/tests/functional/ext/private_import/private_import.py b/tests/functional/ext/private_import/private_import.py
@@ -119,3 +119,16 @@ def c2_func() -> _TypeContainerC.C:
 import _private_module_unreachable # [import-private-name]
 my_var8: _private_module_unreachable.Thing8
 _private_module_unreachable.Thing8()
+
+
+# pylint: disable=too-few-public-methods
+class Regression6624:
+    """Ensure that an import statement precedes this case."""
+    def get_example(self):
+        example: Example = Example().save()
+        return example
+
+
+class Example:
+    def save(self):
+        return self