Add unreachable-match-patterns message and new checker.
#10424
+121
β0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10424 +/- ##
=======================================
Coverage 95.86% 95.87%
=======================================
Files 175 177 +2
Lines 19074 19153 +79
=======================================
+ Hits 18286 18363 +77
- Misses 788 790 +2
π New features to boost your workflow:
|
mbyrnepr2
commented
Jun 12, 2025
``unreachable-match-patterns``. This will emit an error message when a name capture pattern is used in a match statement which would make the remaining patterns unreachable. This code is a SyntaxError at runtime. Closes pylint-dev#7128
mbyrnepr2
force-pushed
the
7128_remaining_patterns_unreachable
branch
from
f1ca097 to
0e5ef7c
Compare
mbyrnepr2
changed the title
remaining-patterns-unreachable checker.unreachable-match-patterns message and new checker.
DanielNoord
reviewed
Jun 16, 2025
| and case.pattern.pattern is None | ||
| and isinstance(case.pattern.name, nodes.AssignName) | ||
| and idx < len(node.cases) - 1 | ||
| and self._py310_plus |
There was a problem hiding this comment.
Why check the version? Shouldn't this always be checked if we find these patterns?
There was a problem hiding this comment.
Why check the version?
My mistake. We shouldn't check it. I must have been thinking that this line would prevent an error from occurring if Pylint was run in an environment using Python 3.9 or lower since the match statement (and the ast.Match node) is only available in Python 3.10 and higher.
The solution would be to remove this line and wait until Python 3.9 is end of life before considering a merge?
DanielNoord
approved these changes
Jun 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This will emit an error message when a name capture pattern is used in a match statement which would make the remaining patterns unreachable. This code is a SyntaxError at runtime.
Closes #7128