Recognize cached_property as property
#4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tiago Honorato <tiagohonorato1@gmail.com>
cdce8p
added
the
False Positive 🦟
Pierre-Sassoulas
approved these changes
Jun 18, 2021
pylint/checkers/utils.py
Outdated
| except astroid.InferenceError: | ||
| pass | ||
| return False | ||
| return _is_property(node) |
There was a problem hiding this comment.
Could this be a function of a FunctionDef instance directly in astroid ?
There was a problem hiding this comment.
After thinking a bit more about it, I'm not sure anymore using _is_property is the right call. If you look at astroid/bases.py, there are quite a few names that are assumed to be properties. It might add more false-positives then it removes.
I'll push a second commit to just add functools.cached_property to _is_property_decorator. That would be the safe choice. Please let me know what you think
There was a problem hiding this comment.
Sounds good, I never saw this POSSIBLE_PROPERTIES const in astroid before.
3 tasks
cdce8p
changed the title
cached_property as property
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #4144 originally authored by @tiagohonorato
Overriding a
propertywithcached_propertycurrently results in aninvalid-overridden-methoderror as the definition for property is too narrow. @hippo91 suggested to useastroid.bases._is_propertywhich seems to work well: #4023 (comment)https://docs.python.org/3/library/functools.html#functools.cached_property
Type of Changes
Related Issue
Closes #4023