[overgeneral-exceptions] Only handle qualified names #8411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Breaking changes for 3.0 π¦€
Maintenance
Pierre-Sassoulas
commented
Mar 9, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8411 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 175 175
Lines 18465 18465
=======================================
Hits 17668 17668
Misses 797 797
|
DanielNoord
approved these changes
Mar 9, 2023
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit a05bc74 |
That sounds like a good change to do. |
Merged
This was referenced Oct 2, 2023
Merged
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
I'm thinking of creating a pylint "check configuration" script, to avoid checking that at run time. Let me know what you think ;)