Fix false positive for keyword-arg-before-vararg
#8571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦l-only parameter with a default value precedes ``*args``. Closes #8570
This comment has been minimized.
This comment has been minimized.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8571 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 174 174
Lines 18369 18371 +2
=======================================
+ Hits 17618 17620 +2
Misses 751 751
|
This comment has been minimized.
This comment has been minimized.
mbyrnepr2
added
the
False Positive π¦
This comment has been minimized.
This comment has been minimized.
DanielNoord
previously approved these changes
Apr 12, 2023
pylint/checkers/typecheck.py
Outdated
| @@ -1001,8 +1001,17 @@ def _compiled_generated_members(self) -> tuple[Pattern[str], ...]: | |||
|
|
|||
| @only_required_for_messages("keyword-arg-before-vararg") | |||
| def visit_functiondef(self, node: nodes.FunctionDef) -> None: | |||
| # check for keyword arg before varargs | |||
| """Check for keyword arg before varargs. | |||
There was a problem hiding this comment.
Bit of a nit but let's keep this as a comment. That makes it easier to later add another check to this visit method.
There was a problem hiding this comment.
Sure! Let me know if it still doesn't look right.
β¦ comment at the top of the method.
DanielNoord
approved these changes
Apr 13, 2023
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 0969d7c |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix false positive for
keyword-arg-before-varargwhen a positional-only parameter with a default value precedes*args.Closes #8570