Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Print statistics how many files were checked in verbose #9122

Merged
merged 11 commits into from
Nov 8, 2023
Merged

Print statistics how many files were checked in verbose #9122

merged 11 commits into from
Nov 8, 2023

Conversation

meltemkenis
Copy link
Contributor

@meltemkenis meltemkenis commented Oct 5, 2023

Type of Changes

Type
Other

Description

While using verbose flag users want to see how many files are included or excluded.
With this PR, after score details, users will see how many files are included or excluded. Example:

Your code has been rated at 7.5/10
Checked 1 files, skipped 0 files

Closes #8935

@Pierre-Sassoulas Pierre-Sassoulas added the Usability Issues related to the usability/UX of pylint label Oct 5, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.1.0 milestone Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #9122 (283eff9) into main (aafa742) will increase coverage by 0.03%.
Report is 31 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9122      +/-   ##
==========================================
+ Coverage   95.76%   95.79%   +0.03%     
==========================================
  Files         173      173              
  Lines       18665    18718      +53     
==========================================
+ Hits        17874    17931      +57     
+ Misses        791      787       -4     
Files Coverage Δ
pylint/lint/pylinter.py 96.25% <100.00%> (+0.02%) ⬆️
pylint/lint/run.py 87.50% <100.00%> (ø)

... and 11 files with indirect coverage changes

@github-actions

This comment has been minimized.

@meltemkenis meltemkenis marked this pull request as ready for review October 9, 2023 20:36
@meltemkenis
Copy link
Contributor Author

@DanielNoord @Pierre-Sassoulas hello, can I get some reviews/ feedbacks for this PR, please?

DanielNoord
DanielNoord previously approved these changes Nov 8, 2023
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we dropped the ball here.

Could you add a news fragment using towncrier?

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had to be more specific. Please see the docs.

You'll need to use towncrier create <IssueNumber>.<type> to create a fragment specific to this PR.

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit!

doc/whatsnew/3/3.1/index.rst Outdated Show resolved Hide resolved
doc/whatsnew/fragments/8935.other Outdated Show resolved Hide resolved
DanielNoord
DanielNoord previously approved these changes Nov 8, 2023
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very sensible change!

And thanks for the ping 😄

@meltemkenis
Copy link
Contributor Author

thank you for your review! 🙂

@DanielNoord
Copy link
Collaborator

@meltemkenis

Ah, you'll need to change the fragment slightly to get pre-commit to pass.

@DanielNoord DanielNoord enabled auto-merge (squash) November 8, 2023 21:38
@DanielNoord DanielNoord merged commit 2b17c39 into pylint-dev:main Nov 8, 2023
42 checks passed
Copy link
Contributor

github-actions bot commented Nov 8, 2023

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 283eff9

@meltemkenis meltemkenis deleted the meltemkenis/Print-statistics-in-verbose branch November 8, 2023 22:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Usability Issues related to the usability/UX of pylint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print statistics how many files were checked in verbose.
3 participants