-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Print statistics how many files were checked in verbose #9122
Print statistics how many files were checked in verbose #9122
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9122 +/- ##
==========================================
+ Coverage 95.76% 95.79% +0.03%
==========================================
Files 173 173
Lines 18665 18718 +53
==========================================
+ Hits 17874 17931 +57
+ Misses 791 787 -4
|
This comment has been minimized.
This comment has been minimized.
@DanielNoord @Pierre-Sassoulas hello, can I get some reviews/ feedbacks for this PR, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we dropped the ball here.
Could you add a news fragment using towncrier
?
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had to be more specific. Please see the docs.
You'll need to use towncrier create <IssueNumber>.<type>
to create a fragment specific to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit!
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very sensible change!
And thanks for the ping 😄
thank you for your review! 🙂 |
Ah, you'll need to change the fragment slightly to get |
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 283eff9 |
Type of Changes
Description
While using verbose flag users want to see how many files are included or excluded.
With this PR, after score details, users will see how many files are included or excluded. Example:
Your code has been rated at 7.5/10
Checked 1 files, skipped 0 files
Closes #8935