Skip to content

Fix suggestion for min-max with expressions #9131

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2023
Merged

Fix suggestion for min-max with expressions #9131

merged 5 commits into from
Oct 11, 2023

Conversation

theirix
Copy link
Contributor

@theirix theirix commented Oct 8, 2023

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Fixes suggestion when list or dict comprehensions are used or combined with add/or operators.

Closes #8524

@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.2 milestone Oct 8, 2023
@github-actions

This comment has been minimized.

# to view
@github-actions

This comment has been minimized.

# to view
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #9131 (ee8234a) into main (317fad2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9131   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files         173      173           
  Lines       18665    18676   +11     
=======================================
+ Hits        17874    17885   +11     
  Misses        791      791
Files Coverage Ξ”
pylint/checkers/nested_min_max.py 100.00% <100.00%> (ΓΈ)

@Pierre-Sassoulas
Copy link
Member

Hmm, I think the primer failed because the interpreter changed when we added python 3.12 in #9092 , would you mind rebasing, please ?

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks pretty good, that's a very nice first contribution πŸ‘ Directly into 3.0.2 πŸ˜„

@theirix theirix force-pushed the nested-min-max-expr branch from 96bf74c to 811d2c0 Compare October 11, 2023 15:29
@github-actions

This comment has been minimized.

# to view
@theirix
Copy link
Contributor Author

theirix commented Oct 11, 2023

Code looks pretty good, that's a very nice first contribution πŸ‘ Directly into 3.0.2 πŸ˜„

Thank you!

Hmm, I think the primer failed because the interpreter changed when we added python 3.12 in #9092 , would you mind rebasing, please ?

Rebased the branch. The only failing check is readthedocs. Please tell me if another rebase is needed when the fix is provided.

@Pierre-Sassoulas
Copy link
Member

Outch, I broke the main branch, fixed by #9140, you can rebase πŸ˜…

@theirix theirix force-pushed the nested-min-max-expr branch from 811d2c0 to ee8234a Compare October 11, 2023 18:48
@Pierre-Sassoulas Pierre-Sassoulas merged commit ce8d1a9 into pylint-dev:main Oct 11, 2023
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@theirix @github-actions
Fix suggestion for min-max with expressions (#9131)
21bd6d4 
Closes #8524

(cherry picked from commit ce8d1a9)
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Merged
@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit ee8234a

Pierre-Sassoulas pushed a commit that referenced this pull request Oct 11, 2023
@github-actions @theirix
Fix suggestion for min-max with expressions (#9131) (#9141)
a9d9dc3 
Closes #8524

(cherry picked from commit ce8d1a9)

Co-authored-by: theirix <theirix@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported Bug πŸͺ²
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

nested-min-max (W3301) is still giving a wrong suggestion in some cases
2 participants
@theirix @Pierre-Sassoulas