-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Catch ParentMissingError in variables checker #9371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9371 +/- ##
==========================================
- Coverage 95.81% 95.80% -0.01%
==========================================
Files 173 173
Lines 18767 18777 +10
==========================================
+ Hits 17981 17989 +8
- Misses 786 788 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the problem for me!
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but any way to cover the new behavior with an automated test ?
I think once we bump astroid these lines will be covered. I'm happy to wait to merge until then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encountered the same error @nickdrozd has while testing. I'd recommend we merge this once all comments are addressed. The astroid
update wouldn't be able to be merged before that anyway as with it some test cases would be failing (which are fixed with this change).
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @jacobtylerwalls 👍🏻
add compatibility with pylint-dev/astroid#2345
some of the unrelated changes here are just for the sake of passing pylint too-many-statements, etc