Fix false positive in use-yield-from when using yield return
#9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the return value from `yield` is inspected inline, such as by (augmented) assignment, changing the looped `yield` to `yield from` is very likely to change the semantics of the generator, since there is an implicit use of `generator.send`. Closes pylint-dev#9696
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9700 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 174 174
Lines 18862 18862
=======================================
Hits 18078 18078
Misses 784 784
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 7222319 |
Pierre-Sassoulas
added
False Positive π¦
Pierre-Sassoulas
approved these changes
Jun 6, 2024
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 6, 2024
β¦) (#9701) If the return value from `yield` is inspected inline, such as by (augmented) assignment, changing the looped `yield` to `yield from` is very likely to change the semantics of the generator, since there is an implicit use of `generator.send`. Closes #9696 (cherry picked from commit ea73bae) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
If the return value from
yieldis inspected inline, such as by (augmented) assignment, changing the loopedyieldtoyield fromis very likely to change the semantics of the generator, since there is an implicit use ofgenerator.send.The type-hint component of #9696 feels (to me) like it would be suitable to suppress with a local lint suppression rather than complex type inference within pylint; it's a pretty unusual construction.
Closes #9696