-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Alter fallback for source-roots #9967
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Alter fallback for source-roots #9967
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9967 +/- ##
==========================================
- Coverage 95.80% 95.80% -0.01%
==========================================
Files 174 174
Lines 18934 18939 +5
==========================================
+ Hits 18140 18144 +4
- Misses 794 795 +1
|
This comment has been minimized.
This comment has been minimized.
648b52c
to
2c0c0d6
Compare
This comment has been minimized.
This comment has been minimized.
As this is not primarily about |
for more information, see https://pre-commit.ci
2bae088
to
6ef3156
Compare
This comment has been minimized.
This comment has been minimized.
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit fed3e42 |
@akamat10 Can you tag me when this is ready for review? |
Will do! |
Hi @akamat10 👋 Just checking in on this PR. Do you think you'll have the chance to pick up where you left off? pylint main is now compatible with astroid main, btw. |
Yes I would love to. Haven't had the chance the last few months as I got busy with some life changes. Also, when I last looked at it, the regression test failures were a little tricky to unravel trying to understand the intent of the test and some unrelated to my changes in the main branch. I will be able to look at it starting March 1st. What kind of timelines do you have in mind for the release? |
The last couple years we've timed the feature release to add compatibility with a new python version in early October, so assuming we do that again you will have plenty of time :) |
Ok sounds good. I will have some update in the first week of March. |
Type of Changes
Description
Alter fallback for source-roots as discussed in #9955. This simplifies the import discovery logic, makes it easier to understand and supports the discovery process for more usecases (for example, src-layout or in cases where imported modules may be in a different directory from the files to be linted)
TODO:
Update changelog and documentation
Closes #9955