Raise SamplingError if model doesn't have free RVs #4955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4955 +/- ##
==========================================
- Coverage 74.08% 74.06% -0.03%
==========================================
Files 86 86
Lines 13862 13862
==========================================
- Hits 10270 10267 -3
- Misses 3592 3595 +3
|
michaelosthege
approved these changes
Aug 20, 2021
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR changes
sample()such that it checks for free RVs in the model immediately (before checking start point), and raises aSamplingErrorinstead of aValueErrorif the model doesn't have any free RVs.I think raising a
SamplingErroris better than aValueError, since nothing value-wise is wrong with the model itself, just sampling is not possible. Also,SamplingErroris more specific thanValueError.