Remove SGMCMC and fix flaky mypy results #5631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
commented
Mar 20, 2022
pymc/distributions/shape_utils.py
Outdated
| @@ -618,4 +618,4 @@ def find_size( | |||
|
|
|||
| def rv_size_is_none(size: Variable) -> bool: | |||
| """Check wether an rv size is None (ie., at.Constant([]))""" | |||
| return size.type.shape == (0,) | |||
| return size.type.shape == (0,) # type: ignore [attr-defined] | |||
There was a problem hiding this comment.
Ideally this should be fixed upstream, but I didn't want to put shape_utils.py onto the list of non-passing files because for shape_utils.py it's quite valuable to enforce mypy checks.
michaelosthege
force-pushed
the
fix-flaky-mypy-results
branch
from
11eea5c to
319ec85
Compare
Codecov Report
@@ Coverage Diff @@
## main #5631 +/- ##
==========================================
+ Coverage 87.63% 88.13% +0.49%
==========================================
Files 76 75 -1
Lines 13717 13641 -76
==========================================
+ Hits 12021 12022 +1
+ Misses 1696 1619 -77
|
ricardoV94
approved these changes
Mar 21, 2022
| @@ -26,8 +26,8 @@ repos: | |||
| - types-filelock | |||
| - types-setuptools | |||
| - arviz | |||
| - aesara==2.4.0 | |||
| - aeppl==0.0.26 | |||
There was a problem hiding this comment.
Oh great, even more places for the dependencies xD
There was a problem hiding this comment.
You can't imagine how delighted I was to learn that the greatness of YAML required me to add the dependencies in yet another place! </sarcasm>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded Aesara and aeppl in the pre-commit environment. Some changes in Aesara's type hints mandated updates here.
For
sampling_jax.pytherun_mypy.pyscript will no longer treat it as an error if it unexpectedly passes. This caused some confusion before.Similarly, I removed
sgmcmc.pywhich was the second file with flaky mypy results.Closes #5580