Skip to content

Allow batched parameters in MvNormal and MvStudentT distributions #6897

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Sep 8, 2023

Also provides default zero mu

Related to #5383


📚 Documentation preview 📚: https://pymc--6897.org.readthedocs.build/en/6897/

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #6897 (c983aff) into main (a3ec9a5) will increase coverage by 0.04%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6897      +/-   ##
==========================================
+ Coverage   92.13%   92.18%   +0.04%     
==========================================
  Files         100      100              
  Lines       16854    16833      -21     
==========================================
- Hits        15529    15517      -12     
+ Misses       1325     1316       -9     
Files Coverage Δ
pymc/distributions/multivariate.py 93.36% <87.50%> (+0.79%) ⬆️

@twiecki
Copy link
Member

twiecki commented Sep 8, 2023

Is this enabled by the new pt.vectorize?

@ricardoV94
Copy link
Member Author

ricardoV94 commented Sep 9, 2023

Is this enabled by the new pt.vectorize?

Yup

@ricardoV94
Copy link
Member Author

The failing tests are fixed by #6903 and latest patch release of PyTensor

@ricardoV94 ricardoV94 force-pushed the incorporate_blockwise branch 2 times, most recently from ad38ee0 to 6b6011e Compare September 14, 2023 07:42
@ricardoV94 ricardoV94 marked this pull request as ready for review September 14, 2023 07:42
@ricardoV94 ricardoV94 force-pushed the incorporate_blockwise branch from 6b6011e to 00cfe5b Compare September 23, 2023 07:55
@ricardoV94 ricardoV94 marked this pull request as draft September 23, 2023 08:02
@ricardoV94
Copy link
Member Author

Need to sort out pymc-devs/pytensor#451 first

@ricardoV94 ricardoV94 force-pushed the incorporate_blockwise branch 2 times, most recently from 40247da to 070a76e Compare September 27, 2023 16:17
@ricardoV94
Copy link
Member Author

PR now depends on pymc-devs/pytensor#459 and future 2.16.4 PyTensor release.

@ricardoV94 ricardoV94 added major Include in major changes release notes section and removed major Include in major changes release notes section labels Oct 2, 2023
@ricardoV94
Copy link
Member Author

This now depends on #6934

@ricardoV94 ricardoV94 force-pushed the incorporate_blockwise branch from 5092435 to c983aff Compare October 2, 2023 14:29
@ricardoV94 ricardoV94 marked this pull request as ready for review October 2, 2023 14:32
Copy link
Member

@fonnesbeck fonnesbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants