Implement Ordered distribution factory #7603
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Dec 3, 2024
| def support_point_ordered(op, rv, dist): | ||
| # FIXME: This does not work with the default ordered transform | ||
| # It leads to a -inf log_jac_det | ||
| # return support_point(dist) |
There was a problem hiding this comment.
@aseyboldt @lucianopaz any idea if we could easily modify the OrderedTransform to work nicely with equal values in the constrained space? The current one maps a [0, 0, 0] vector to [0, -inf, -inf]. My guess is not.
But then I don't have a nice way to define a valid support_point. I could try to add an increasing jitter but that will sooner or later fail for bounded distributions.
lucianopaz
reviewed
Dec 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7297
📚 Documentation preview 📚: https://pymc--7603.org.readthedocs.build/en/7603/