Skip to content

Fix numpy DeprecationWarning when converting integers to PyTensor Constants #238

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 9, 2023

Led to #198 failing

Closes #146

@ricardoV94 ricardoV94 changed the title Fix numpy DeprecationWarning when converting integers to numpy arrays Fix numpy DeprecationWarning when converting integers to constants Mar 9, 2023
@ricardoV94 ricardoV94 changed the title Fix numpy DeprecationWarning when converting integers to constants Fix numpy DeprecationWarning when converting integers to PyTensor Constants Mar 9, 2023
@ricardoV94 ricardoV94 force-pushed the fix_numpy_deprecated_upcast branch 2 times, most recently from dedb31f to d108f19 Compare March 9, 2023 16:32
@ricardoV94 ricardoV94 force-pushed the fix_numpy_deprecated_upcast branch from d108f19 to 7bb114c Compare March 9, 2023 17:13
@codecov-commenter
Copy link

Codecov Report

Merging #238 (7bb114c) into main (0b632bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   80.42%   80.43%           
=======================================
  Files         170      170           
  Lines       45329    45328    -1     
  Branches     9687     9687           
=======================================
+ Hits        36458    36461    +3     
+ Misses       6645     6643    -2     
+ Partials     2226     2224    -2     
Impacted Files Coverage Δ
pytensor/misc/safe_asarray.py 69.23% <100.00%> (ø)
pytensor/tensor/extra_ops.py 89.27% <0.00%> (-0.29%) ⬇️
pytensor/scan/rewriting.py 79.94% <0.00%> (+0.51%) ⬆️

@ricardoV94 ricardoV94 merged commit c28db53 into pymc-devs:main Mar 9, 2023
@ricardoV94 ricardoV94 changed the title Fix numpy DeprecationWarning when converting integers to PyTensor Constants Fix numpy DeprecationWarning when converting integers to PyTensor Constants Apr 7, 2023
@ricardoV94 ricardoV94 deleted the fix_numpy_deprecated_upcast branch June 21, 2023 08:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy deprecation warning when converting python integers
3 participants