Add an epsilon parameter to RegressionDiscontinuity classes
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 70.34% 70.40% +0.05%
==========================================
Files 19 19
Lines 1005 1007 +2
==========================================
+ Hits 707 709 +2
Misses 298 298
|
…nDiscontinuity class
juanitorduz
requested changes
Jul 24, 2023
juanitorduz
approved these changes
Jul 24, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epsilon is the (small) distance above and below the threshold that we use to calculate the discontinuity. Previously this was hard-wired to be 0.001, but now we have a kwarg
epsilonthat can be used to override the default (still 0.001).Added a short description in the docstring.
Added use of the kwarg into the integration tests.
Closes #220.