Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Automate pre commit updates #322

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Apr 30, 2024

This PR adds the feature to use https://pre-commit.ci/ to generate automatic version updates of the pre-commit versions. This is already working on pymc-marketing: https://github.com/pymc-labs/pymc-marketing/blob/main/.pre-commit-config.yaml Note I deleted the GitHub action as it will be a duplicate after this one is merged (pymc-devs/pymc#7285)

@drbenvincent Can you please log into https://pre-commit.ci/ and grant access to this repository after we merge this PR? We then can start getting these automatic PRs as in pymc-labs/pymc-marketing#655

I ran pre-commit run --all-files to verify everything was working as expected. The result is that some files were modified just by adding a white space.

@juanitorduz
Copy link
Collaborator Author

The failure of PyPI release / Build source distribution (pull_request) Failing because

WARNING: Requirement '../dist/CausalPy*.tar.gz' looks like a filename, but the file does not exist
Processing /home/runner/work/CausalPy/CausalPy/dist/CausalPy*.tar.gz
ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/home/runner/work/CausalPy/CausalPy/dist/CausalPy*.tar.gz'

seems related to pymc-labs/pymc-marketing#633 but I am not sure about the fix.

@juanitorduz juanitorduz added the devops DevOps related label Apr 30, 2024
@juanitorduz
Copy link
Collaborator Author

The failure of PyPI release / Build source distribution (pull_request) Failing because

WARNING: Requirement '../dist/CausalPy*.tar.gz' looks like a filename, but the file does not exist
Processing /home/runner/work/CausalPy/CausalPy/dist/CausalPy*.tar.gz
ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/home/runner/work/CausalPy/CausalPy/dist/CausalPy*.tar.gz'

seems related to pymc-labs/pymc-marketing#633 but I am not sure about the fix.

it seems e13b919 solved it 😀

@juanitorduz juanitorduz self-assigned this Apr 30, 2024
@drbenvincent
Copy link
Collaborator

Great work. Loving the cross-pollination from pymc-marketing.

Happy to merge, but we seem to have a bunch of failing tests when run remotely. Tests all pass locally.

@juanitorduz
Copy link
Collaborator Author

@drbenvincent will you fix these tests in another PR? If so I can rebase afterwards :)

@drbenvincent
Copy link
Collaborator

Ah I see. The failing doctests are also failing on other PR's, so not caused by this. Will merge.

@drbenvincent drbenvincent merged commit c7b8c26 into main May 2, 2024
3 of 5 checks passed
@drbenvincent drbenvincent deleted the automate-pre-commit-updates branch May 2, 2024 11:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
devops DevOps related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants