Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MMM] Model events as gaussian bumps #1465

Merged
merged 8 commits into from
Feb 4, 2025
Merged

[MMM] Model events as gaussian bumps #1465

merged 8 commits into from
Feb 4, 2025

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Feb 3, 2025

Gaussian bumps are very common to model events, see for example https://juanitorduz.github.io/bump_func/


📚 Documentation preview 📚: https://pymc-marketing--1465.org.readthedocs.build/en/1465/

@juanitorduz juanitorduz self-assigned this Feb 3, 2025
@github-actions github-actions bot added the MMM label Feb 3, 2025
@juanitorduz juanitorduz added this to the 0.12.0 milestone Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (eb3b6b6) to head (b112fe7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   94.68%   94.80%   +0.11%     
==========================================
  Files          50       51       +1     
  Lines        5456     5505      +49     
==========================================
+ Hits         5166     5219      +53     
+ Misses        290      286       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just adding some comments

@github-actions github-actions bot added the tests label Feb 4, 2025
@juanitorduz juanitorduz requested a review from wd60622 February 4, 2025 13:32
@juanitorduz
Copy link
Collaborator Author

@wd60622 I did some cleanup and added some tests and docs. Please let me know what do you think about it and also feel free to push directly to the branch.

I a next PR I will add other even models (from my blog)

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. You should link your blog post in the docs as reference

@wd60622 wd60622 merged commit 542a85b into main Feb 4, 2025
19 of 20 checks passed
@wd60622 wd60622 deleted the special_events_gauss branch February 4, 2025 14:42
@wd60622 wd60622 added the enhancement New feature or request label Feb 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants