Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: object oriented device API #38

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

I quite like how it feels to use the object-oriented device API in pymmcore-plus. this implements it in C++

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 10.83123% with 354 lines in your changes missing coverage. Please review.

Project coverage is 23.59%. Comparing base (00c86ad) to head (31661ea).

Files with missing lines Patch % Lines
src/DeviceHandle.cpp 6.81% 243 Missing and 3 partials ⚠️
src/_pymmcore_nano.cc 21.64% 64 Missing and 12 partials ⚠️
src/DeviceHandle.h 11.11% 28 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   24.08%   23.59%   -0.49%     
==========================================
  Files          90       92       +2     
  Lines        6710     7098     +388     
  Branches     3516     3546      +30     
==========================================
+ Hits         1616     1675      +59     
- Misses       3773     4073     +300     
- Partials     1321     1350      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title object oriented device API feat: object oriented device API Feb 18, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant