feat: set sequence fov size in engine setup_sequence + add test #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdrgsp
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 86.18% 86.24% +0.06%
==========================================
Files 29 29
Lines 1831 1839 +8
==========================================
+ Hits 1578 1586 +8
Misses 253 253 ☔ View full report in Codecov by Sentry. |
|
@fdrgsp , is this ready to go and still relevant? |
Yes, it is ready to go. now. |
tlambert03
approved these changes
Jul 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
useq.MDASequence_fov_sizeattribute (https://github.com/pymmcore-plus/useq-schema/blob/8bac21de522dd09dc5302fb11f8000ce87eb95e9/src/useq/_mda_sequence.py#LL120C5-L120C65) in theMDAEnginewhen thesetup_sequencemethod is called + testrelated to closed PR pymmcore-plus/pymmcore-widgets#142.