Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fix bug in sequencing #225

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

tlambert03
Copy link
Member

This fixes a bug in canSequenceEvents when one of the two events has an x,y, or z position of 0

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14% ⚠️

Comparison is base (9fc18a6) 86.80% compared to head (b50d019) 86.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   86.80%   86.66%   -0.14%     
==========================================
  Files          31       31              
  Lines        2220     2220              
==========================================
- Hits         1927     1924       -3     
- Misses        293      296       +3     
Files Changed Coverage Δ
src/pymmcore_plus/core/_sequencing.py 73.95% <100.00%> (-3.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 63d2d2f into pymmcore-plus:main Jul 28, 2023
@tlambert03 tlambert03 deleted the fix-seq branch July 28, 2023 00:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant