Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: remove loguru #239

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Aug 4, 2023

closes #238

we don't use many of the loguru features, and it brings on an unneeded extra dependency, and the possibility of conflict with stdlib logging

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 86.15% and project coverage change: +0.04% 🎉

Comparison is base (f098e60) 86.63% compared to head (d8b244f) 86.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   86.63%   86.67%   +0.04%     
==========================================
  Files          31       31              
  Lines        2259     2274      +15     
==========================================
+ Hits         1957     1971      +14     
- Misses        302      303       +1     
Files Changed Coverage Δ
src/pymmcore_plus/_util.py 83.63% <20.00%> (ø)
src/pymmcore_plus/core/_mmcore_plus.py 89.08% <66.66%> (ø)
src/pymmcore_plus/_logger.py 81.81% <90.90%> (+2.22%) ⬆️
src/pymmcore_plus/_cli.py 93.18% <100.00%> (ø)
src/pymmcore_plus/mda/_engine.py 94.82% <100.00%> (ø)
src/pymmcore_plus/mda/_runner.py 92.42% <100.00%> (+0.63%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 652aa69 into pymmcore-plus:main Aug 4, 2023
@tlambert03 tlambert03 deleted the remove-loguru branch August 4, 2023 18:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How should code that uses pymmcore-plus emit log messages?
1 participant