Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: support DeviceInitializationState, fix issue with microscope model #276

Merged
merged 4 commits into from
Oct 21, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03
Copy link
Member Author

this also fixes an issue with the microscope model tests resulting from micro-manager/mmCoreAndDevices#376

see discussion in micro-manager/mmCoreAndDevices#384

@tlambert03 tlambert03 changed the title feat: add getDeviceInitializationState and DeviceInitializationState feat: support DeviceInitializationState, fix issue with microscope model Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4e8ae9a) 92.02% compared to head (f090df7) 91.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   92.02%   91.92%   -0.11%     
==========================================
  Files          44       44              
  Lines        3297     3305       +8     
==========================================
+ Hits         3034     3038       +4     
- Misses        263      267       +4     
Files Coverage Δ
src/pymmcore_plus/__init__.py 100.00% <ø> (ø)
src/pymmcore_plus/core/__init__.py 100.00% <ø> (ø)
src/pymmcore_plus/core/_constants.py 98.95% <100.00%> (+0.02%) ⬆️
src/pymmcore_plus/model/_core_device.py 96.15% <ø> (ø)
src/pymmcore_plus/model/_microscope.py 96.89% <100.00%> (+0.04%) ⬆️
src/pymmcore_plus/core/_mmcore_plus.py 91.99% <66.66%> (-0.15%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

the fix for widgets is in pymmcore-plus/pymmcore-widgets#234

@tlambert03 tlambert03 merged commit 31f2396 into pymmcore-plus:main Oct 21, 2023
@tlambert03 tlambert03 deleted the DeviceInitializationState branch October 21, 2023 14:19
tlambert03 added a commit to tlambert03/pymmcore-plus that referenced this pull request Dec 6, 2023
…del (pymmcore-plus#276)

* feat: add getDeviceInitializationState and DeviceInitializationState

* fix apply_to_core

* expose name

* fix docs
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant