Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: create Microscope (model) from summary metadata #359

Merged
merged 30 commits into from
Jun 29, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jun 23, 2024

This PR follows on #358 and allows creating an instance of pymmcore_plus.model.Microscope from a SummaryMetaV1 dict, with pymmcore_plus.model.Microscope.from_summary_metadata As a reminder, the Microscope object is mostly used as a runtime representation of a non-loaded Core. It's used to create config files, and is used by the pymmcore-widgets ConfigWizard. So, with this PR, it would be straightforward to load the full state of the core as used in a previous experiment

@tlambert03 tlambert03 changed the title create Microscope (model) from summary metadata feat: create Microscope (model) from summary metadata Jun 23, 2024
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (412066d) to head (972bc6f).
Report is 13 commits behind head on main.

Files Patch % Lines
src/pymmcore_plus/model/_microscope.py 85.71% 1 Missing ⚠️
src/pymmcore_plus/model/_pixel_size_config.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   91.62%   91.61%   -0.01%     
==========================================
  Files          53       53              
  Lines        4165     4188      +23     
==========================================
+ Hits         3816     3837      +21     
- Misses        349      351       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 23, 2024

CodSpeed Performance Report

Merging #359 will not alter performance

Comparing tlambert03:model-from-meta (972bc6f) with main (412066d)

Summary

✅ 5 untouched benchmarks

@tlambert03 tlambert03 merged commit e0cb4c0 into pymmcore-plus:main Jun 29, 2024
23 of 24 checks passed
@tlambert03 tlambert03 deleted the model-from-meta branch June 29, 2024 14:59
@tlambert03 tlambert03 added the enhancement New feature or request label Aug 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant