-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: create Microscope (model) from summary metadata #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
- Coverage 91.62% 91.61% -0.01%
==========================================
Files 53 53
Lines 4165 4188 +23
==========================================
+ Hits 3816 3837 +21
- Misses 349 351 +2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #359 will not alter performanceComparing Summary
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on #358 and allows creating an instance of
pymmcore_plus.model.Microscope
from aSummaryMetaV1
dict, withpymmcore_plus.model.Microscope.from_summary_metadata
As a reminder, theMicroscope
object is mostly used as a runtime representation of a non-loaded Core. It's used to create config files, and is used by the pymmcore-widgets ConfigWizard. So, with this PR, it would be straightforward to load the full state of the core as used in a previous experiment