Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: convert all relative imports to absolute imports #29

Conversation

agriyakhetarpal
Copy link
Member

Description

This is a small PR that does some cleanup I wanted to do for a while:

Relative imports are not bad, it's just that absolute imports are nicer, at least to me :)

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I often use relative imports just to not repeat the package name everywhere, but I don't have much preference, so I am okay with this change.

@agriyakhetarpal
Copy link
Member Author

That's a valid reason to use them, too!

@agriyakhetarpal agriyakhetarpal merged commit f1f36bd into pyodide:main Sep 17, 2024
6 checks passed
@agriyakhetarpal agriyakhetarpal deleted the chore/convert-relative-imports-to-absolute branch September 17, 2024 01:07
@agriyakhetarpal agriyakhetarpal mentioned this pull request Sep 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants