Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move test file unvendoring functionality from pyodide-build to pyodide-lock #30

Open
ryanking13 opened this issue Jun 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ryanking13
Copy link
Member

When creating a pyodide-lock file, we separate test codes inside the wheel and pack them in a separate file to reduce the size of the wheel. This feature is highly related to the lockfile, so I think it would be nice to move it to pyodide-lock so users can use it when creating a custom lockfile using out-of-tree wheels.

On the other hand, if we move this functionality to pyodide-lock, we should support some ways to specify which packages should have their test files split and which should not. We were using unvendor_tests in the meta.yaml file, but the recipe file will not be available for out-of-tree builds.

So, probably we would need some cmdline flags such as:

--vendor-tests pkg-name pkg-name2

and also make it configurable using a config file:

[tool.pyodide.lock]
vendor-tests = ['pkg-name', 'pkg-name2']

This can also be extended to general unvendoring mechanism not only for test files as discussed in pyodide/pyodide#3092.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant