Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MAINT Unvendor tests at the lockfile creation step #116

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ryanking13
Copy link
Member

@ryanking13 ryanking13 commented Mar 6, 2025

This PR changes when test codes are unvendored.

Before:

  • it is unvendored right after the wheel file is built (== at the same step when build.post script runs).
  • when generating a lockfile, we check if the test codes are unvendored and update the lockfile entry.

After:

  • it is unvendored when we are creating a lockfile.

Why?

I would like to move the unvendoring logic to somewhere else like pyodide-pack or pyodide-lock (pyodide/pyodide-lock#30, pyodide/pyodide-pack#41), so package maintainers can use that feature when they are not using a recipe.


Related issues:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant