Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace print statements with logger #109

Closed
ehashman opened this issue Oct 20, 2018 · 2 comments
Closed

Replace print statements with logger #109

ehashman opened this issue Oct 20, 2018 · 2 comments
Labels
enhancement good first issue has PR

Comments

@ehashman
Copy link
Member

Self-explanatory.
@aaronchall
Copy link
Contributor

Let me try to tackle this one!

@ehashman
Copy link
Member Author

ehashman commented Oct 27, 2018 •
edited
Loading

auditwheel/auditwheel/wheel_abi.py

Line 18 in 5a56bca

log = logging.getLogger(__name__)

Example of use of logger... use your best judgement for info/error/debug

aaronchall added a commit to aaronchall/auditwheel that referenced this issue Oct 27, 2018
@aaronchall
issue pypa#109 Replace statements with logger
2389a59
aaronchall added a commit to aaronchall/auditwheel that referenced this issue Oct 27, 2018
@aaronchall
issue pypa#109 Replace print statements with logger (after merge)
cc16208
@anthrotype anthrotype mentioned this issue Oct 28, 2018
Closed
@aaronchall aaronchall mentioned this issue Nov 13, 2018
Merged
ehashman pushed a commit that referenced this issue Nov 13, 2018
@aaronchall @ehashman
issue #109 Replace print statements with logger (#113)
f5af970 
* Replace `print` statements with logger (issue #109)

* Use pytest>=3.4

* Configure pytest in setup.cfg
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement good first issue has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronchall @ehashman