Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added Python 3.7 to the CI. #127

Merged
merged 5 commits into from
Nov 18, 2018
Merged

Added Python 3.7 to the CI. #127

merged 5 commits into from
Nov 18, 2018

Conversation

atombrella
Copy link
Contributor

No description provided.

ehashman
ehashman reviewed Nov 13, 2018
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to add 3.7 this way: travis-ci/travis-ci#9815

Test failures seem to be network-related.

@atombrella atombrella force-pushed the python_3_7 branch 2 times, most recently from 35dc6a3 to 5b1305d Compare November 15, 2018 20:27
@atombrella
Copy link
Contributor Author

@ehashman It works without sudo, at least Travis didn't give any errors. I fixed the import-warnings of collections in this PR as well.

@jamadden
Copy link
Member

jamadden commented Nov 15, 2018 •
edited
Loading

Using sudo at all is no longer recommended by Travis:

Please update your build configurations to remove the sudo: configuration option as soon as is convenient.

@ehashman
Copy link
Member

@jamadden Previously using sudo was the only way for Docker on Travis to work. Has that changed as well?

@jamadden
Copy link
Member

Effectively, sudo is true by default now, and builds that do not specify any value for sudo run on a full VM instead of a container. One of the originally stated reasons for that was specifically to make using docker easier:

More and more folks are building and deploying Docker images, and using Docker within a container-based build is not a great experience

ehashman
ehashman approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh we can deal with the sudo thing later. LGTM.

Going to hold off on merging this for a bit to give some older PRs some love.

@ehashman
Copy link
Member

There are some merge conflicts that will need to be resolved :)

@ehashman
Merge branch 'master' into python_3_7
bc5aeaa 
Conflicts:
	auditwheel/main_show.py
	auditwheel/wheel_abi.py
@ehashman
Drop 3.4 support, too
bcb5036
@ehashman
Copy link
Member

Apparently switching the 3.5 build to xenial was the kick in the pants Travis needed. Fingers crossed this won't break as soon as it hits master again... merging.

@ehashman ehashman merged commit 4da18e3 into pypa:master Nov 18, 2018
@atombrella atombrella deleted the python_3_7 branch December 7, 2018 20:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ehashman ehashman ehashman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atombrella @jamadden @ehashman