Show all shared libraries found in purelib #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
force-pushed
the
list-all-shared-libraries-in-purelib
branch
from
2fd9f26 to
0e94f7a
Compare
|
Dustin, in case is it possible to add a test for the proposed changes? The code looks nice though |
di
force-pushed
the
list-all-shared-libraries-in-purelib
branch
from
0e94f7a to
7f64f91
Compare
|
@auvipy I've added a test and resolved the merge conflicts. |
lkollar
reviewed
Jun 5, 2019
lkollar
approved these changes
Jun 5, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just outputting the first shared library found in
purelib, include a list of all offending files.