Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix running 'wheelhouse' test script on Travis CI #168

Closed
wants to merge 3 commits into from
Closed

Fix running 'wheelhouse' test script on Travis CI #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b537ef
Fix running 'wheelhouse' test script on Travis CI
takluyver Jun 15, 2019
6547885
Switch wheelhouse script back to Nathaniel's wheels
takluyver Jun 15, 2019
afe77d2
Remove wheelhouse test from allow_failures
takluyver Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ matrix:
env: WHEELHOUSE=1
- python: "3.6"
- python: "3.7"
allow_failures:
- python: "3.5"
env: WHEELHOUSE=1

sudo: required
services:
Expand Down
15 changes: 2 additions & 13 deletions tests/integration/test-wheelhouses.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,8 @@
set -e

# Download some wheels from one location
PY_VERS="2.7 3.3 3.4 3.5"
for PYVER in ${PY_VERS}; do
wget "https://github.com/getnikola/wheelhouse/archive/v${PYVER}.zip"
unzip "v${PYVER}.zip"
done

# Download some other wheels that Nathaniel made
#URL=https://vorpus.org/~njs/tmp/manylinux-test-wheels/original/
#curl --silent $URL | grep 'a href' | grep whl | cut -d ' ' -f 8 | cut -d '=' -f 2 | cut -d '"' -f 2 | xargs -n1 -I '{}' wget --no-check-certificate -P wheelhouse-njs "$URL/{}"

# Download some more wheels that Robert made
URL=http://stanford.edu/~rmcgibbo/wheelhouse/
curl --silent $URL | grep 'a href' | grep whl | cut -d ' ' -f 8 | cut -d '=' -f 2 | cut -d '"' -f 2 | xargs -n1 -I '{}' wget -P wheelhouse-rmcgibbo "$URL/{}" -nc
URL=https://vorpus.org/~njs/tmp/manylinux-test-wheels/original/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not include these wheels in the source repo instead? We already have a few under the tests directory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't want to clutter up the source repo with various multi-MB wheels; large binary files are a bit awkward to handle in git. This test can also easily be expanded to many more wheels, e.g. I saw this scikit-learn wheelhouse linked from #86.

Copy link
Member

@mayeut mayeut Jun 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way not to clutter up the source repo with various multi-MB wheels would be to use git-lfs.

curl --silent $URL | grep 'a href' | grep whl | cut -d ' ' -f 8 | cut -d '=' -f 2 | cut -d '"' -f 2 | xargs -n1 -I '{}' wget --no-check-certificate -P wheelhouse-njs "$URL/{}"

# These are boring
rm -f wheelhouse*/*-none-any.whl
Expand Down
2 changes: 1 addition & 1 deletion tests/travis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -exo pipefail

if [[ "$WHEELHOUSE" == "1" ]]; then
bash tests/test-wheelhouses.sh
bash tests/integration/test-wheelhouses.sh
else
pytest -s
auditwheel lddtree $(python -c 'import sys; print(sys.executable)')
Expand Down