Clear rpath before setting #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably want to squash your commits as there 15 in total and several have duplicate commit message. It doesn’t look quite right... |
auvipy
approved these changes
Jun 27, 2019
daa
force-pushed
the
clear-rpath-before-setting
branch
from
450feb7 to
2f21d2f
Compare
|
Squashed, sorry for inconvenience. |
lkollar
requested changes
Jun 27, 2019
auvipy
approved these changes
Jun 29, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bug in patchelf NixOS/patchelf#94 if shared object has DT_RUNPATH attribute it is not replaced with DT_RPATH if --force-rpath is given, so one must clear all rpath attributes before setting new.
This pull request closes #29.
Also this pull request is resubmit of #133 because old showed too much changed files and it is easier for me to resubmit.