Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correctly detect non-platform wheels #224

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented Jan 28, 2020

We are not checking if there are any ELF files in the wheel when
inspecting the wheel ABI. This can lead to misleading results when
invoking 'show' and an uncaught exception in other modes.

Resolves: #218

We are not checking if there are any ELF files in the wheel when
inspecting the wheel ABI. This can lead to misleading results when
invoking 'show' and an uncaught exception in other modes.
@lkollar lkollar self-assigned this Jan 28, 2020
@lkollar lkollar force-pushed the non-platform-wheel branch from 301f95c to 36c865b Compare January 28, 2020 23:03
@auvipy auvipy requested a review from di January 29, 2020 06:44
@lkollar lkollar removed the request for review from di February 3, 2020 22:59
@lkollar lkollar changed the title Correctly detect non-platform wheels [WIP] Correctly detect non-platform wheels Feb 3, 2020
@lkollar lkollar changed the title [WIP] Correctly detect non-platform wheels Correctly detect non-platform wheels Feb 13, 2020
@lkollar
Copy link
Contributor Author

lkollar commented Feb 13, 2020

This is ready for review. The s390x build is still failing due to running out of space on the image: https://travis-ci.community/t/no-space-left-on-device-for-system-z/5954/9.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #224 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #224     +/-   ##
=========================================
- Coverage   89.54%   89.25%   -0.3%     
=========================================
  Files          19       19             
  Lines         976      996     +20     
  Branches      214      215      +1     
=========================================
+ Hits          874      889     +15     
- Misses         63       65      +2     
- Partials       39       42      +3
Impacted Files Coverage Δ
auditwheel/main_show.py 72.22% <100%> (-4.87%) ⬇️
auditwheel/main_repair.py 76.59% <100%> (+4.5%) ⬆️
auditwheel/wheel_abi.py 98.4% <100%> (+0.08%) ⬆️
auditwheel/main_addtag.py 86.84% <100%> (+1.54%) ⬆️
auditwheel/repair.py 81.17% <0%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d864b5e...cd3874e. Read the comment docs.

@lkollar lkollar force-pushed the non-platform-wheel branch 2 times, most recently from 760ea01 to cd3874e Compare February 26, 2020 23:09
@lkollar lkollar merged commit 3b1d9ef into pypa:master Feb 27, 2020
@lkollar lkollar deleted the non-platform-wheel branch May 2, 2020 08:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auditwheel addtag returns stack trace when given a none-any wheel
2 participants