Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove usage of wheel imported helpers for python 2/3 compatibility #276

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Dec 17, 2020

Those helpers are only helpful for python 2/3 compatibility, they're not necessary as auditwheel has been python 3 only since its 1st version.

Those helpers are only helpful for python 2/3 compatibility, they're not necessary as `auditwheel` has been python 3 only since its 1st version.
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #276 (c80ca9a) into master (8640b8f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   90.89%   90.88%   -0.01%     
==========================================
  Files          20       20              
  Lines        1043     1042       -1     
  Branches      223      223              
==========================================
- Hits          948      947       -1     
  Misses         54       54              
  Partials       41       41              
Impacted Files Coverage Δ
auditwheel/condatools.py 100.00% <100.00%> (ø)
auditwheel/wheeltools.py 91.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8640b8f...c80ca9a. Read the comment docs.

@mayeut mayeut merged commit ebaac3c into pypa:master Dec 17, 2020
@mayeut mayeut deleted the cleanup-wheel-unused branch December 17, 2020 18:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants