-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use PEP600 policy names #288
Conversation
8be4ef5
to
c840c6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 90.63% 90.99% +0.35%
==========================================
Files 20 20
Lines 1079 1088 +9
Branches 232 234 +2
==========================================
+ Hits 978 990 +12
+ Misses 57 55 -2
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
Failure on TravisCI ppc64le is unrelated to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One thing we should consider is to list the aliases on the --help
explicitly. Right now this can be a bit confusing:
--plat {linux_x86_64,manylinux_2_5_x86_64,manylinux_2_12_x86_64,manylinux_2_17_x86_64,manylinux_2_24_x86_64,manylinux1_x86_64,manylinux2010_x86_64,manylinux2014_x86_64}
Maybe we should list the "old" platform tags separatly as legacy tags.
They should be allowed to be compatible with existing usage of
Maybe adding an epilogue:
|
Add legacy aliases for `manylinux_2_5`, `manylinux_2_12` & `manylinux_2_17` The platform tag passed to `auditwheel repair` `--plat` argument can use either the PEP600 tag or the legacy tag. The repaired wheel will get both platform tags. e.g. `auditwheel repair --plat manylinux1_x86_64 foo-5.0-cp38-cp38-linux_x86_64.whl` and `auditwheel repair --plat manylinux_2_5_x86_64 foo-5.0-cp38-cp38-linux_x86_64.whl` will both produce `foo-5.0-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.whl`
c840c6a
to
69c2d62
Compare
@lkollar, |
Add legacy aliases for
manylinux_2_5
,manylinux_2_12
&manylinux_2_17
The platform tag passed to
auditwheel repair
--plat
argument can use either the PEP600 tag or the legacy tag.The repaired wheel will get both platform tags.
e.g.
auditwheel repair --plat manylinux1_x86_64 foo-5.0-cp38-cp38-linux_x86_64.whl
andauditwheel repair --plat manylinux_2_5_x86_64 foo-5.0-cp38-cp38-linux_x86_64.whl
will both producefoo-5.0-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.whl
Builds on top of #287