Remove dependency on pkg_resources
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkollar
force-pushed
the
remove-pkg_resources
branch
from
4c47f8c to
6d091a7
Compare
The only reason we needed this was to look at the version metadata and the installation location. We can do this with `importlib.metadata` which is part of Python since 3.8 and is significantly faster to import than `pkg_resources`.
lkollar
force-pushed
the
remove-pkg_resources
branch
from
6d091a7 to
6bdc458
Compare
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 91.24% 91.28% +0.03%
==========================================
Files 20 20
Lines 1097 1102 +5
Branches 237 237
==========================================
+ Hits 1001 1006 +5
Misses 54 54
Partials 42 42
Continue to review full report at Codecov.
|
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason we needed this was to look at the version metadata and
the installation location. We can do this with
importlib.metadatawhich is part of Python since 3.8 and is significantly faster to import
than
pkg_resources.Closes: #306