Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added libresolv to the whitelisted libraries #81

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

dvarrazzo
Copy link
Contributor

Fix #80

@njsmith
Copy link
Member

njsmith commented Aug 26, 2017

Ugh, it looks like the Travis tests have bitrotted. @rmcgibbo @ehashman any ideas?

@ehashman
Copy link
Member

Hmmmm, at first glance I don't think this is bitrotted. If we add a new file to the policy we'll need to also ensure all its symbols are represented in the policy list. Perhaps that's why this failed?

@njsmith
Copy link
Member

njsmith commented Aug 26, 2017

The library's part of glibc so it shouldn't need any new symbols.

From a quick glance it looked like the tests were failing because they were trying to fetch some remote url and getting a 404.

@ehashman
Copy link
Member

looks at Travis build

Aha, I dunno what https://github.com/getnikola/wheelhouse/archive/v2.7.zip is but it's 404ing. That definitely isn't a test I wrote. Will let y'all take a look first.

@cblackwell-dw
Copy link

Is anyone working on fixing these build problems? They seem unrelated to this pull request. This issue affects other libraries that we are building our own wheels for; for example mysqlclient.

@rmcgibbo
Copy link
Member

rmcgibbo commented Nov 7, 2017

I don't think anyone is working on fixing the build problems. It's my code / my fault. The 404 is surely because I found some wheels on github to use as tests.

If anyone has the bandwidth to clean up the tests a little bit -- even just remove the failing test -- that would be great.

@ehashman
Copy link
Member

ehashman commented Nov 7, 2017

I'll see if I can just remove it for now.

@rmcgibbo
Copy link
Member

rmcgibbo commented Nov 7, 2017

(cc #86)

@ehashman
Copy link
Member

ehashman commented Nov 8, 2017

Hi @dvarrazzo, you can now rebase this PR and the build should pass!

@dvarrazzo
Copy link
Contributor Author

Ready to merge

@ehashman ehashman merged commit 5b8b569 into pypa:master Nov 17, 2017
@dvarrazzo dvarrazzo deleted the whitelist-libresolv branch November 20, 2017 14:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants