Process non-Python binaries (e.g. binary executables) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to relocate and distribute executable binaries as well as Python extension binaries.
|
Looks plausible at a quick glance. Can you add a test though? That would make it much easier to have some confidence that it actually works :-). |
ehashman
approved these changes
Jul 3, 2018
This was referenced Oct 18, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to relocate and distribute executable binaries as well as Python extension binaries.
We would like to use this feature in the LALSuite package. See https://git.ligo.org/lscsoft/lalsuite/merge_requests/164.