Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't require toml in [test] on Python 3.11+ #563

Closed
wants to merge 1 commit into from

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jan 16, 2023

The test_toml_instead_of_tomli test is skipped on Python 3.11 anyway.

The test_toml_instead_of_tomli test is skipped on Python 3.11 anyway.
@layday
Copy link
Member

layday commented Jan 16, 2023

I think we can just drop toml, it's been completely supplanted by tomli.

@hroncok
Copy link
Contributor Author

hroncok commented Jan 16, 2023

If you wish to drop the fallback to toml, that also works for me.

@frenzymadness
Copy link

Now there is 'tomli >= 1.1.0; python_version < "3.11"' in dependencies, "toml >= 0.10.0" in test deps and "tomli" in typing deps.

@layday
Copy link
Member

layday commented Jan 18, 2023

We have toml in test deps because we are testing against it. We have tomli in the typing deps because mypy simulates Python 3.7 and on 3.11, tomli is not required.

@hroncok
Copy link
Contributor Author

hroncok commented Jan 18, 2023

Now there is 'tomli >= 1.1.0; python_version < "3.11"' in dependencies, "toml >= 0.10.0" in test deps and "tomli" in typing deps.

After this PR, the toml dependency is also conditional.

@henryiii
Copy link
Contributor

I think we should drop toml, but this is a (small) step forward.

@layday
Copy link
Member

layday commented Jan 20, 2023

I've got a PR to drop toml ready to go but I wanted to get #537 in first to avoid having to deal with merge conflicts. If you wanna get this in in the interim, we can do so, but I don't think there's much point unless we are gonna cut a release without toml as a test dependency.

@layday
Copy link
Member

layday commented Jan 25, 2023

#567

@layday
Copy link
Member

layday commented Jan 27, 2023

Merged #567.

@layday layday closed this Jan 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants